jdbm.btree.BTree |
Line |
check contract for BPages to be removed from recman. |
371
|
jdbm.recman.TransactionManager |
Line |
Handle the case where we are recovering lg9 and lg0, were we should start with lg9 instead of lg0! |
63
|
org.apache.directory.server.changepw.protocol.ChangepwProtocolHandlerTest |
Line |
Check if this method is important or not. It was called in the testInitialFlagRequired() method above, but this call has been commented private void processChangePasswordReply( ChangePasswordReply reply, EncryptionKey sessionKey, EncryptionKey subSessionKey ) throws Exception { PrivateMessage privateMessage = reply.getPrivateMessage(); <p/> EncryptedData encPrivPart = privateMessage.getEncryptedPart(); <p/> EncKrbPrivPart privPart; <p/> try { privPart = ( EncKrbPrivPart ) cipherTextHandler.unseal( EncKrbPrivPart.class, subSessionKey, encPrivPart, KeyUsage.NUMBER13 ); } catch ( KerberosException ke ) { return; } <p/> // Verify result code. byte[] resultCode = privPart.getUserData(); <p/> assertTrue( "Password change returned SUCCESS (0x00 0x00).", Arrays.equals( SUCCESS, resultCode ) ); } |
190
|
org.apache.directory.server.changepw.service.ChangePasswordService |
Line |
- check ticket is for service authorized to change passwords ticket.getServerPrincipal().getName().equals(config.getChangepwPrincipal().getName())); |
240
|
- check client principal in ticket is authorized to change password |
243
|
org.apache.directory.server.core.DefaultCoreSession |
Line |
- has not been completed yet |
69
|
- need to supply controls and other parameters to setup opContexts |
70
|
Auto-generated method stub |
139
|
Auto-generated method stub |
149
|
Auto-generated method stub |
182
|
Auto-generated method stub |
192
|
Auto-generated method stub |
202
|
Auto-generated method stub |
212
|
- perhaps we should just use a flag that is calculated on creation of this session |
218
|
- this method impl does not check to see if the principal is in the administrators group - it only returns true of the principal is the actual admin user. need to make it check groups. |
231
|
- perhaps we should just use a flag that is calculated on creation of this session |
235
|
fix this so it checks groups |
247
|
Auto-generated method stub |
465
|
org.apache.directory.server.core.DefaultDirectoryService |
Line |
review this code. |
735
|
- confirm if we need this at all since the group cache on initialization after this stage will search the directory for all the groups anyway |
1052
|
do nothing ... |
1453
|
Let's get rid of this Attributes crap |
1482
|
org.apache.directory.server.core.DefaultOperationManager |
Line |
- need to remove Context caller and PartitionNexusProxy from Invocations |
404
|
- need to remove Context caller and PartitionNexusProxy from Invocations |
412
|
org.apache.directory.server.core.OperationManager |
Line |
document after determining if this method should be here. |
57
|
document after determining if this method should be here. |
63
|
document after determining if this method should be here. |
69
|
document after determining if this method should be here. |
75
|
document after determining if this method should be here. |
81
|
document after determining if this method should be here. |
87
|
document after determining if this method should be here. |
93
|
document after determining if this method should be here. |
99
|
document after determining if this method should be here. |
105
|
document after determining if this method should be here. |
111
|
document after determining if this method should be here. |
117
|
document after determining if this method should be here. |
123
|
document after determining if this method should be here. |
129
|
document after determining if this method should be here. |
135
|
document after determining if this method should be here. |
141
|
document after determining if this method should be here. |
147
|
document after determining if this method should be here. |
153
|
org.apache.directory.server.core.authn.AuthenticationInterceptor |
Line |
- authentication level not being set |
461
|
we should refactor that. try each authenticator |
471
|
org.apache.directory.server.core.authn.SimpleAuthenticator |
Line |
use an enum for the algorithm |
419
|
org.apache.directory.server.core.authz.AciAuthorizationInterceptor |
Line |
- eventually replace this with a check on session.isAnAdministrator() |
692
|
this method returns a boolean : what should we do with the result ? |
828
|
org.apache.directory.server.core.authz.AutzIntegUtils |
Line |
might be ServerDNConstants.ADMIN_SYSTEM_DN_NORMALIZED |
206
|
org.apache.directory.server.core.authz.support.RelatedProtectedItemFilterTest |
Line |
I don't know how to test with Refinement yet. |
247
|
org.apache.directory.server.core.authz.support.RelatedUserClassFilterTest |
Line |
Don't know how to test yet. |
152
|
org.apache.directory.server.core.changelog.ChangeLogInterceptor |
Line |
handle correctly http://issues.apache.org/jira/browse/DIRSERVER-1198 |
252
|
org.apache.directory.server.core.changelog.MemoryChangeLogStore |
Line |
remove the NamingException |
53
|
org.apache.directory.server.core.changelog.SearchableChangeLogStore |
Line |
SearchableChangeLogStore. |
24
|
org.apache.directory.server.core.changelog.TaggableSearchableChangeLogStore |
Line |
TaggableSearchableChangeLogStore. |
26
|
org.apache.directory.server.core.collective.CollectiveAttributeInterceptor |
Line |
- Instead of hitting disk here can't we leverage the SubentryService to get us cached sub-entries so we're not wasting time with a lookup here? It is ridiculous to waste time looking up this sub-entry. |
201
|
org.apache.directory.server.core.collective.CollectiveAttributesSchemaChecker |
Line |
Replace the Exception and the ResultCodeEnum with the correct ones. |
73
|
Replace the Exception and the ResultCodeEnum with the correct ones. |
97
|
handle http://issues.apache.org/jira/browse/DIRSERVER-1198 |
110
|
org.apache.directory.server.core.cursor.ListCursor |
Line |
might want to add some code here to utilize the comparator |
224
|
might want to add some code here to utilize the comparator |
255
|
org.apache.directory.server.core.entry.DefaultServerAttributeTest |
Line |
forbid addition of more than 1 value for SINGLE-VALUE attributes |
1108
|
org.apache.directory.server.core.entry.ServerEntryUtils |
Line |
handle options. |
209
|
- after removing JNDI we need to make the server handle this in the codec |
458
|
handle options |
473
|
- after removing JNDI we need to make the server handle this in the codec |
505
|
handle options |
520
|
org.apache.directory.server.core.interceptor.BaseInterceptor |
Line |
delete this since it uses static access Returns {@link LdapPrincipal} of current context. |
77
|
delete this since it uses static access Returns the current JNDI {@link Context}. |
88
|
org.apache.directory.server.core.interceptor.InterceptorChainTest |
Line |
Auto-generated method stub |
603
|
Auto-generated method stub |
610
|
org.apache.directory.server.core.interceptor.context.AbstractOperationContext |
Line |
- need synchronization here and where we update links |
314
|
org.apache.directory.server.core.jndi.EventListenerAdapter |
Line |
for the time being bindings in NamingEvents generated are not relative to the source context which they should be. |
51
|
presume correctly manipulated entry values in opContext.getEntry() objects to function properly - at this point this is not handled in the Interceptors and needs to be added for this adapter to populate the event bindings. |
54
|
- Should we factor in the attributes to be returned in bindings? Perhaps this should be privided as search controls along with the info we need to handle aliases, and referals? |
59
|
not utilized but should be to effect returns in bindings, alias and referral handling |
73
|
org.apache.directory.server.core.normalization.NormalizationInterceptor |
Line |
Normalize the returned Attributes, storing the UP attributes to format the returned values. |
181
|
org.apache.directory.server.core.normalization.NormalizingVisitor |
Line |
implement the logic for ExtensibleNode |
455
|
org.apache.directory.server.core.partition.DefaultPartitionNexus |
Line |
since we're handling the *, and + in the EntryFilteringCursor we may not need this code: we need see if this is actually the case and remove this code. |
848
|
handle searches based on the RootDSE |
960
|
not implemented until we can use id to figure out the partition using the partition ID component of the 64 bit Long identifier |
1137
|
org.apache.directory.server.core.partition.PartitionNexusProxy |
Line |
check if we can find another way to protect ourselves from recursion. |
626
|
not implemented until we can lookup partition using the partition id component of the 64 bit identifier |
787
|
org.apache.directory.server.core.partition.impl.btree.BTreePartition |
Line |
- add sub level index setter |
418
|
shouldn't this be a BigInteger instead of an int? |
525
|
org.apache.directory.server.core.partition.impl.btree.gui.PartitionFrame |
Line |
use utility method to getIndices below model = new AttributesTableModel( partition.getIndices( id ), id, dn, false ); idxTbl.setModel( model ); |
876
|
org.apache.directory.server.core.partition.impl.btree.jdbm.JdbmIndex |
Line |
I don't think the keyCache is required anymore since the normalizer will cache values for us. |
643
|
org.apache.directory.server.core.partition.impl.btree.jdbm.JdbmStore |
Line |
Change signature to not require the DN parameter since it is now in the ServerEntry !!! |
957
|
org.apache.directory.server.core.partition.impl.btree.jdbm.JdbmTable |
Line |
make the size of the duplicate btree cache configurable via constructor |
108
|
org.apache.directory.server.core.prefs.PreferencesIT |
Line |
Temporarily commented until we get a clear status about this package |
109
|
org.apache.directory.server.core.schema.MetaDitContentRuleHandler |
Line |
Auto-generated constructor stub |
44
|
Auto-generated method stub |
55
|
Auto-generated method stub |
65
|
Auto-generated method stub |
75
|
Auto-generated method stub |
86
|
Auto-generated method stub |
97
|
Auto-generated method stub |
107
|
Auto-generated method stub |
114
|
Auto-generated method stub |
120
|
org.apache.directory.server.core.schema.MetaDitStructureRuleHandler |
Line |
Auto-generated constructor stub |
44
|
Auto-generated method stub |
57
|
Auto-generated method stub |
68
|
Auto-generated method stub |
79
|
Auto-generated method stub |
93
|
Auto-generated method stub |
107
|
Auto-generated method stub |
118
|
Auto-generated method stub |
125
|
Auto-generated method stub |
131
|
org.apache.directory.server.core.schema.MetaMatchingRuleUseHandler |
Line |
Auto-generated constructor stub |
44
|
Auto-generated method stub |
52
|
Auto-generated method stub |
58
|
Auto-generated method stub |
64
|
Auto-generated method stub |
71
|
Auto-generated method stub |
78
|
Auto-generated method stub |
84
|
Auto-generated method stub |
90
|
Auto-generated method stub |
96
|
org.apache.directory.server.core.schema.MetaNameFormHandler |
Line |
Auto-generated constructor stub |
44
|
Auto-generated method stub |
57
|
Auto-generated method stub |
68
|
Auto-generated method stub |
79
|
Auto-generated method stub |
92
|
Auto-generated method stub |
105
|
Auto-generated method stub |
116
|
Auto-generated method stub |
123
|
Auto-generated method stub |
129
|
org.apache.directory.server.core.schema.MetaSchemaHandler |
Line |
might want to add a set of failedOnXXX methods to the adapter where on failure the schema service calls the schema manager and it calls the appropriate methods on the respective handler. This way the schema manager can rollback registry changes when LDAP operations fail. |
223
|
- for now we're just going to add the schema to the global registries ... we may need to add it to more than that though later. |
464
|
log warning: schemaName + " was already loaded" |
471
|
org.apache.directory.server.core.schema.MetaSyntaxCheckerHandlerIT |
Line |
Auto-generated method stub |
628
|
org.apache.directory.server.core.schema.PartitionSchemaLoader |
Line |
need ot confirm this ( or we must make the class for this and use deferred resolution until everything is available? |
367
|
Auto-generated method stub |
379
|
Auto-generated method stub |
385
|
Auto-generated method stub |
391
|
Auto-generated method stub |
397
|
org.apache.directory.server.core.schema.PartitionSchemaLoaderTest |
Line |
move this to core-integ does not belong here and get rid of all the static |
60
|
org.apache.directory.server.core.schema.SchemaChecker |
Line |
we really need to refactor this code since there's much duplication |
53
|
org.apache.directory.server.core.schema.SchemaInterceptor |
Line |
/ handle http://issues.apache.org/jira/browse/DIRSERVER-1198 |
1292
|
org.apache.directory.server.core.sp.LdapClassLoader |
Line |
we should cache this information and register with the event service to get notified if this changes so we can update the cached copy - there's absolutely no reason why we should be performing this lookup every time!!! |
140
|
- why is this an operation???? Why can't we just list these damn things who went stupid crazy making everything into a damn operation !!!! grrrr |
184
|
org.apache.directory.server.core.subtree.SubentryInterceptor |
Line |
why are we doing this here if we got the entry from the opContext in the first place - got to look into this |
499
|
why are we doing this here if we got the entry from the opContext in the first place - got to look into this |
578
|
org.apache.directory.server.core.subtree.SubtreeEvaluator |
Line |
Try to make this cast unnecessary. |
77
|
org.apache.directory.server.core.trigger.SimpleTriggerExecutionAuthorizer |
Line |
Auto-generated catch block |
43
|
org.apache.directory.server.core.trigger.StoredProcedureParameterInjector |
Line |
- can we get some documentation on this? |
30
|
org.apache.directory.server.core.trigger.TriggerInterceptor |
Line |
Get this from the configuration if needed. |
252
|
Replace the Authorization Code with a REAL one. |
561
|
org.apache.directory.server.core.trigger.TriggerInterceptorIT |
Line |
- change the spec to make this pass |
100
|
org.apache.directory.server.dhcp.protocol.DhcpDecoder |
Line |
Auto-generated method stub |
55
|
org.apache.directory.server.kerberos.kdc.KdcServer |
Line |
- for now ignoring this catelog crap |
427
|
org.apache.directory.server.kerberos.kdc.authentication.AuthenticationService |
Line |
- fetch lastReq for this client; requires store |
572
|
- resp.key-expiration := client.expiration; requires store |
574
|
org.apache.directory.server.kerberos.kdc.ticketgrant.TicketGrantingService |
Line |
- resp.last-req := fetch_last_request_info(client); requires store |
392
|
- currently no transited support other than local |
893
|
org.apache.directory.server.kerberos.shared.KerberosUtils |
Line |
- check server key version number, skvno; requires store |
380
|
- doesn't take into account skew |
450
|
org.apache.directory.server.kerberos.shared.store.MultiBaseSearch |
Line |
are exception messages reasonable? I changed them to use the catalog key rather than the catalog value. |
47
|
org.apache.directory.server.ldap.gui.ShutdownProgress |
Line |
Auto-generated catch block |
66
|
org.apache.directory.server.ldap.handlers.BindHandler |
Line |
- might cause issues since lookups are not returning all attributes right now - this is an optimization that can be enabled later after determining whether or not this will cause issues. reuse the looked up entry so we don't incur another lookup opContext.setEntry( principalEntry ); |
164
|
- why is this exception being ignored? Isn't this really bad? |
492
|
org.apache.directory.server.ldap.handlers.LdapRequestHandler |
Line |
- session you get from LdapService should have the ldapService member already set no? Should remove these lines where ever they may be if that's the case. |
121
|
org.apache.directory.server.ldap.handlers.ReferralAwareRequestHandler |
Line |
- fix this by access unormalized RDN values seems we have to do this because get returns normalized rdns |
666
|
- fix this by access unormalized RDN values seems we have to do this because get returns normalized rdns |
758
|
org.apache.directory.server.ldap.handlers.bind.AbstractSaslCallbackHandler |
Line |
- figure out how to handle this properly. |
215
|
org.apache.directory.server.ldap.handlers.bind.cramMD5.CramMd5MechanismHandler |
Line |
- don't use session properties anymore |
50
|
org.apache.directory.server.ldap.handlers.bind.digestMD5.DigestMd5CallbackHandler |
Line |
- should return not be a byte[] |
78
|
org.apache.directory.server.operations.search.SearchIT |
Line |
enable this test here Failing here below this due to the frontend interpretting the byte[] as a String value. I see the value sent to the SearchHandler of the filter to be a String looking like: "[B@17210a5". |
277
|
org.apache.directory.server.protocol.shared.StandardThreadPool |
Line |
wont this hang if some tasks are sufficiently badly behaved? |
49
|
org.apache.directory.server.schema.bootstrap.SystemComparatorProducer |
Line |
Inject the AttributeType registry into the caching normalizer. |
76
|
org.apache.directory.server.tools.DisconnectNotificationCommand |
Line |
Auto-generated catch block |
92
|
org.apache.directory.server.tools.GracefulShutdownCommand |
Line |
Auto-generated catch block |
143
|
org.apache.directory.server.unit.AbstractServerTest |
Line |
shouldn't this be before calling configureLdapServer() ??? |
271
|
- set some sort of default NtlmProvider implementation here ntlmMechanismHandler.setNtlmProvider( provider ); |
296
|
- or set FQCN of some sort of default NtlmProvider implementation here ntlmMechanismHandler.setNtlmProviderFqcn( "com.foo.BarNtlmProvider" ); |
298
|
org.apache.directory.server.xdbm.search.impl.AndCursor |
Line |
- duplicate code from AndEvaluator just make utility for this and for the same code in the OrEvaluator once done. |
176
|
org.apache.directory.server.xdbm.search.impl.ApproximateEvaluator |
Line |
check to see if descendant handling is necessary for the index so we can match properly even when for example a name attribute is used instead of more specific commonName |
114
|
- determine if comaparator and index entry should have the Value wrapper or the raw normalized value |
169
|
org.apache.directory.server.xdbm.search.impl.EqualityEvaluator |
Line |
check to see if descendant handling is necessary for the index so we can match properly even when for example a name attribute is used instead of more specific commonName |
138
|
- determine if comaparator and index entry should have the Value wrapper or the raw normalized value |
173
|
org.apache.directory.server.xdbm.search.impl.GreaterEqEvaluator |
Line |
check to see if descendant handling is necessary for the index so we can match properly even when for example a name attribute is used instead of more specific commonName |
163
|
check to see if descendant handling is necessary for the index so we can match properly even when for example a name attribute is used instead of more specific commonName |
215
|
- determine if comaparator and index entry should have the Value wrapper or the raw normalized value |
239
|
org.apache.directory.server.xdbm.search.impl.LessEqEvaluator |
Line |
check to see if descendant handling is necessary for the index so we can match properly even when for example a name attribute is used instead of more specific commonName |
171
|
check to see if descendant handling is necessary for the index so we can match properly even when for example a name attribute is used instead of more specific commonName |
212
|
- determine if comaparator and index entry should have the Value wrapper or the raw normalized value |
236
|
org.apache.directory.server.xdbm.search.impl.OneLevelScopeEvaluator |
Line |
- terribly inefficient - would benefit from exposing the id of an entry within the ServerEntry |
134
|
org.apache.directory.server.xdbm.search.impl.OrCursor |
Line |
- do same evaluator fail fast optimization that we do in AndCursor |
52
|
org.apache.directory.server.xdbm.search.impl.PresenceEvaluator |
Line |
- determine if comaparator and index entry should have the Value wrapper or the raw normalized value |
83
|
- determine if comaparator and index entry should have the Value wrapper or the raw normalized value |
105
|
- determine if comaparator and index entry should have the Value wrapper or the raw normalized value |
118
|
check to see if descendant handling is necessary for the index so we can match properly even when for example a name attribute is used instead of more specific commonName |
136
|
org.apache.directory.server.xdbm.search.impl.SubstringEvaluator |
Line |
- determine if comaparator and index entry should have the Value wrapper or the raw normalized value |
237
|
- determine if comaparator and index entry should have the Value wrapper or the raw normalized value |
245
|
check to see if descendant handling is necessary for the index so we can match properly even when for example a name attribute is used instead of more specific commonName |
281
|
- determine if comaparator and index entry should have the Value wrapper or the raw normalized value |
323
|
check to see if descendant handling is necessary for the index so we can match properly even when for example a name attribute is used instead of more specific commonName |
376
|
org.apache.directory.server.xdbm.tools.StoreUtils |
Line |
might want to make this load an LDIF instead in the future |
55
|
correct size of spaces in user provided DN |
56
|